Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner code, a little improvement in performance #7

Merged
merged 1 commit into from Dec 13, 2018

Conversation

MaximeBouton
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 95

  • 18 of 21 (85.71%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 65.974%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/episode_replay.jl 0 1 0.0%
src/solver.jl 18 20 90.0%
Files with Coverage Reduction New Missed Lines %
src/dueling.jl 1 87.5%
src/solver.jl 3 63.85%
Totals Coverage Status
Change from base Build 83: -0.7%
Covered Lines: 254
Relevant Lines: 385

💛 - Coveralls

@codecov-io
Copy link

Codecov Report

Merging #7 into master will decrease coverage by 0.69%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #7     +/-   ##
=========================================
- Coverage   66.66%   65.97%   -0.7%     
=========================================
  Files           9        9             
  Lines         396      385     -11     
=========================================
- Hits          264      254     -10     
+ Misses        132      131      -1
Impacted Files Coverage Δ
src/episode_replay.jl 63.49% <0%> (ø) ⬆️
src/solver.jl 63.84% <90%> (-1.41%) ⬇️
src/dueling.jl 87.5% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9f183e...d383194. Read the comment docs.

@MaximeBouton MaximeBouton merged commit 895837b into master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants