-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDP/POMDP support #25
Comments
Seems better to use UnderlyingMDP because then it's not an expectation for all MDP solver writers to also support POMDPs, but it is kind of annoying to have to find it. One option is to make both solvers accept pomdps but throw a warning that says to use UnderlyingMDP. In the end, I think it's probably just most convenient to have both solvers accept both just for convenience. |
I agree that in general MDP solvers should not be required to support POMDPs. The main reason why Discrete VI supports POMDPs is because it is used in QMDP.jl I think. An alternative is to have a SparseQMDP solver. Then in QMDP.jl it should use UnderlyingMDP. |
So it seems like the best thing to do is @deprecate solve(s::ValueIterationSolver, m::POMDP) solve(s, UnderlyingMDP(m)) and throw a similar warning for SparseValueIterationSolver, in QMDP, we should really have a |
Fixed JuliaPOMDP/QMDP.jl#15 and #32 |
The vanilla solver supports both MDPs and POMDPs. Should the Sparse solver support POMDPs as well?
The current way that one can use it to solve a POMDP is as follows:
The text was updated successfully, but these errors were encountered: