Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SparseTabularMDP from POMDPModelTools #32

Merged
merged 9 commits into from
Aug 13, 2019
Merged

Use SparseTabularMDP from POMDPModelTools #32

merged 9 commits into from
Aug 13, 2019

Conversation

MaximeBouton
Copy link
Contributor

  • Use SparseTabularMDP
  • solve methods only for MDP

TODO: add a warning for POMDPs?

@MaximeBouton
Copy link
Contributor Author

Restart travis after JuliaRegistries/General#2643 gets merged

@MaximeBouton
Copy link
Contributor Author

The build fails in 0.7, I think we can safely drop the support.
Any objections @zsunberg @rejuvyesh ?

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@95f407d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   97.72%           
=========================================
  Files             ?        4           
  Lines             ?      132           
  Branches          ?        0           
=========================================
  Hits              ?      129           
  Misses            ?        3           
  Partials          ?        0
Impacted Files Coverage Δ
src/sparse.jl 90.9% <100%> (ø)
src/vanilla.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f407d...e739781. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@95f407d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   97.72%           
=========================================
  Files             ?        4           
  Lines             ?      132           
  Branches          ?        0           
=========================================
  Hits              ?      129           
  Misses            ?        3           
  Partials          ?        0
Impacted Files Coverage Δ
src/sparse.jl 90.9% <100%> (ø)
src/vanilla.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95f407d...e739781. Read the comment docs.

@mykelk
Copy link
Member

mykelk commented Aug 13, 2019

Sounds good to me.

@zsunberg
Copy link
Member

The build fails in 0.7, I think we can safely drop the support.
Any objections @zsunberg @rejuvyesh ?

drop it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants