deprecated AlphaVectorPolicy(m, alphas) #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
zsunberg
added a commit
to JuliaPOMDP/IncrementalPruning.jl
that referenced
this pull request
Jun 7, 2019
zsunberg
added a commit
to JuliaPOMDP/QMDP.jl
that referenced
this pull request
Jun 7, 2019
|
Ha, wow, actually I already found a bug because of this in FIB - the action ordering might not be right for some problems |
zsunberg
added a commit
to JuliaPOMDP/FIB.jl
that referenced
this pull request
Jun 7, 2019
This was referenced Jun 7, 2019
zsunberg
added a commit
to JuliaPOMDP/AEMS.jl
that referenced
this pull request
Jun 7, 2019
zsunberg
added a commit
to JuliaPOMDP/ParticleFilters.jl
that referenced
this pull request
Jun 7, 2019
zsunberg
added a commit
to JuliaPOMDP/ParticleFilters.jl
that referenced
this pull request
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AlphaVectorPolicy(m, alphas)constructor seems really dangerous to me - it seems very easy to accidentally make alpha vectors match up with the wrong actions.Is it ok if I deprecate it in favor of
AlphaVectorPolicy(m, alphas, action_map)so that people explicitly have to specify which actions the alpha vectors correspond to?I'll go back and make sure no solvers use the two argument one if we accept this.