-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State-dependent action spaces in POMDP are not transfered to underlying MDP #429
Comments
Hi @AlexBork , thanks for reporting. One issue is that Another option would be for you to define
What do you think about that? If you still think that adding the method you proposed to |
Actually I guess that Line 19 in 52ee24c
Can you submit a PR (this would be great practice if you haven't done it before!), or should I make the change? |
Hey @zsunberg, thank you very much for the swift answer. I will submit a PR containing the change. |
Fixes underlying MDP not preserving the state-dependent actions of POMDP (See: JuliaPOMDP#429)
) * Fix for underlying MDP Fixes underlying MDP not preserving the state-dependent actions of POMDP (See: #429) * Added test
The call of an underlying MDP for a POMDP does not preserve state-dependent action spaces, i.e. calling
actions(UnderlyingMDP(pomdp), s)
for a POMDP with state-dependent action space yields a wrong result.Adding
to ModelTools/underlying_mdp.jl fixes the problem.
I propose adding the fix to the main repository.
The text was updated successfully, but these errors were encountered: