Remove latest observation from CommonRLEnv POMDP state #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it inconsistent that
state(::MDPCommonRLEnv)
returns the state (converted to typeRLO
) butstate(::POMDPCommonRLEnv)
returns a state-observation tuple, without converting anything. Since the observation is not really part of the state, I think it makes sense to not provide it as part ofstate(::POMDPCommonRLEnv)
. Additionally, the state should also be optionally converted to another type, just like the observation.This PR implements the proposed changes.