Add ref to algorithm #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found it helpful that the algorithms carry a literature reference. As a POMDP newbie it took me a while to find the corresponding paper so I could check the details. So this PR is a suggestion to add it for this algo.
mykelk
reviewed
Jun 25, 2018
README.md
Outdated
| This Julia package implements the QMDP approximate solver for POMDP/MDP planning. | ||
| This Julia package implements the QMDP approximate solver for POMDP/MDP planning. The QMDP solver is documented in: | ||
|
|
||
| * Michael Littman, Anthony Cassandra, and Leslie Kaelbling. [Learning policies for partially observable environments: Scaling up. In Armand Prieditis and Stuart Russell](http://citeseerx.ist.psu.edu/viewdoc/summary?doi=10.1.1.52.6374), editors, Proceedings of the Twelfth International Conference on Machine Learning, pages 362--370, San Francisco, CA, 1995. Morgan Kaufmann. |
There was a problem hiding this comment.
The In Armand Prieditis and Stuart Russell should be either removed out moved outside of the link.
|
@hoehleatsu Thank you! I implemented Mykel's suggestion and will merge as soon as the checks pass. |
|
Thanks for the review, improvement and merging the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would find it helpful, if the description of the algorithms carries a literature reference. Currently the description is very short so as a POMDP newbie it took me a while to find the corresponding paper. This PR is a suggestion to add it for this algo, feel free to quote a more appropriate paper instead.