Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shard Bump #23

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Shard Bump #23

merged 3 commits into from
Aug 17, 2020

Conversation

staticfloat
Copy link
Member

@staticfloat staticfloat force-pushed the sf/shard_bump branch 4 times, most recently from 6bb6b3c to 059202a Compare August 17, 2020 21:46
@staticfloat
Copy link
Member Author

@giordano this, alongside the companion branch in BB, passes all tests. I'll let you take a look before merging both, although I don't think there's anything too crazy in here.

giordano
giordano approved these changes Aug 17, 2020
View reviewed changes
Project.toml
@@ -19,7 +19,7 @@ UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
CodecZlib = "0.5, 0.6, 0.7"
JSON = "0.21"
OutputCollectors = "0.1"
julia = "1.3"
julia = "1.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to Base having to do with color. 🙄

@staticfloat staticfloat merged commit edaf6b4 into master Aug 17, 2020
@staticfloat staticfloat deleted the sf/shard_bump branch August 17, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@staticfloat @giordano