download all artifacts with concurrent tasks #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Nov 25, 2022
| verbose && @info "launch $concurrency concurrent downloading tasks" | ||
| wait(taskpool) | ||
| @sync for _ in 1:concurrency | ||
| @async begin |
There was a problem hiding this comment.
For new code I recommend against the use of @async and strongly prefer Threads.@spawn.
|
Side note: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It takes quite a long time to wait for each artifact to be downloaded if it's in a sequential manner, so I figure it might be worth adding concurrent support here.
But I'm not sure if this is implemented well. For instance, the downloading tasks can't be correctly killed if I hit Ctrl-C. Does Julia have a "standard" way of doing so? I found https://discourse.julialang.org/t/stop-terminate-a-sub-task-started-with-async/32193 but am not sure if that's okay to use.