-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use curl
temporarily until Downloads
fixes make their way into 1.6
#54
Conversation
292c34e
to
914e6f5
Compare
Using this
I have dev'ed |
src/ArchiveUtils.jl
Outdated
# Temporarily shell out to `curl` to download, until `Downloads` bugs are squashed | ||
try | ||
run(`curl -C - -s -\# -f -L $(url) -o $(path)`) | ||
catch e | ||
# Downloads throws an ErrorException, so we'll do the same | ||
error("download failed: $(e)") | ||
end | ||
#Downloads.download(url, path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue for me:
# Temporarily shell out to `curl` to download, until `Downloads` bugs are squashed | |
try | |
run(`curl -C - -s -\# -f -L $(url) -o $(path)`) | |
catch e | |
# Downloads throws an ErrorException, so we'll do the same | |
error("download failed: $(e)") | |
end | |
#Downloads.download(url, path) | |
mkpath(dirname(path)) | |
Downloads.download(url, path) |
Ok, the tests are much entangled with LibCURL, which now broke.... |
Looking better to the log, I believe the issue is that we're always installing |
No description provided.