Do not download again sources that are already cached #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
Oct 20, 2020
Comment on lines
133
to
+136
| src_path = abspath(source.url) | ||
|
|
||
| # And if this is a locally-sourced tarball, just verify | ||
| verify(src_path, source.hash) | ||
| verify(src_path, source.hash) || error("Verification failed") |
There was a problem hiding this comment.
To be honest, I have no idea why we have this branch. I'm leaving it as it is, but I don't know when we have sources that are local files
There was a problem hiding this comment.
Unsurprisingly, these are 2 of the only 3 lines missing in code coverage in this file 😄
giordano
force-pushed
the
mg/fix-download
branch
2 times, most recently
from
cf9ae70
to
f3e96df
Compare
|
Ahhhhhh, of course. The old |
giordano
force-pushed
the
mg/fix-download
branch
from
f3e96df
to
15bec36
Compare
giordano
commented
Oct 20, 2020
Comment on lines
+131
to
+133
| @info "Cached file found in $(path)" | ||
| else | ||
| @info "Downloading $(url) to $(path)..." |
There was a problem hiding this comment.
I hope these logging messages are fine. I know this is a bit verbose, but they're very useful for debugging and making sure we're doing what we're supposed to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JuliaPackaging/BinaryBuilder.jl#928