Pass -mmacosx-version-min on clang as well as gcc
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Nov 13, 2020
staticfloat
force-pushed
the
sf/macos_version_min
branch
from
91239a6
to
b0a7967
Compare
I originally wanted to add the ability for the `os_version` tag in the target to change things automatically, but we need to slightly update the compiler shards first (e.g. remove the `14` from the paths in the compiler shard and whatnot).
staticfloat
force-pushed
the
sf/macos_version_min
branch
from
b0a7967
to
bd7faa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally wanted to add the ability for the
os_versiontag in thetarget to change things automatically, but we need to slightly update
the compiler shards first (e.g. remove the
14from the paths in thecompiler shard and whatnot).