Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

Fix API of choose_download to return nothing #134

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

staticfloat
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 21, 2018

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #134   +/-   ##
======================================
  Coverage    88.4%   88.4%           
======================================
  Files           8       8           
  Lines         647     647           
======================================
  Hits          572     572           
  Misses         75      75
Impacted Files Coverage Δ
src/PlatformNames.jl 95.97% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb403e6...f5091f7. Read the comment docs.

@ararslan ararslan merged commit c409fa2 into master Oct 22, 2018
@ararslan ararslan deleted the sf/nothing_api branch October 22, 2018 20:50
visr pushed a commit to visr/BinaryProvider.jl that referenced this pull request May 10, 2019
)

* Autodetect privileged container necessity

* We don't need to be so verbose now that BinaryProvider auto-prints when
downloading even if `verbose` is false.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants