Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: global init block #50

Open
maleadt opened this issue Oct 27, 2022 · 1 comment
Open

Feature request: global init block #50

maleadt opened this issue Oct 27, 2022 · 1 comment

Comments

@maleadt
Copy link

maleadt commented Oct 27, 2022

The init_block argument to build_tarballs currently generates code that's executed when a specific wrapper is found. That's generally fine, but in some cases we might also want to perform an action when no wrapper is available (say, perform system discovery, or log a message). I'd therefore like to propose to add a global_init_block argument to build_tarballs, and adapt JLLWrappers to call the wrappers' init functions from a global __init__ instead.

Thoughts?

@giordano
Copy link
Member

giordano commented Jan 4, 2023

I'm generally ok with adding more placeholders for greater flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants