Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass explicit path to Artifact file into the artifact string macro #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KristofferC
Copy link
Member

Requires JuliaLang/julia#46755 to be merged and us to get a version name for that commit.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #45 (119035d) into master (f6f6abe) will decrease coverage by 0.95%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   54.05%   53.09%   -0.96%     
==========================================
  Files           7        7              
  Lines         222      226       +4     
==========================================
  Hits          120      120              
- Misses        102      106       +4     
Impacted Files Coverage Δ
src/wrapper_generators.jl 54.83% <16.66%> (-8.13%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@giordano
Copy link
Member

Tests are still failing on nightly

@giordano giordano closed this Jan 4, 2023
@giordano giordano reopened this Jan 4, 2023
@giordano
Copy link
Member

giordano commented Jan 5, 2023

Tests on nightly are always failing

@KristofferC
Copy link
Member Author

The julia PR got changed before merge which broke it JuliaLang/julia#46755 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants