Widen version compat #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 84.44% 84.44%
=======================================
Files 1 1
Lines 90 90
=======================================
Hits 76 76
Misses 14 14
Continue to review full report at Codecov.
|
|
The failures on 1.7 for win and mac don't appear related and are present for me locally on 1.7 with both win and mac. |
MichaelHatherly
added a commit
to MichaelHatherly/TimeZones.jl
that referenced
this pull request
Jun 9, 2021
Fixes JuliaTime#338. At module init runs the current `build` to generate the cached data, and stores it in a scratchspace instead of the deps folder. Associated globals that were defined at top-level are now set in `__init__` (and `_init` for submodules) to allow for `PackageCompiler` support. Scratchspace is linked to the Julia and package version so should rebuild when those change for users. The `deps/build.jl` now just imports the package which triggers a build of the cache if needed so this shouldn't really impact `using TimeZones` much as far as I could tell. A required PR for `Scratch` to expand it's version support is at JuliaPackaging/Scratch.jl#24. I've enabled support going back to 1.0 for that package to match what `TimeZones` says it supports, but it turns out `EzXML` is bounded at `1.3` so I couldn't test down to 1.0-1.2.
We used to ensure the orphanage was empty by asserting the file does not exist. We are now content if the file is empty as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22. It seems all that was needed was to check for existence of
active_projectsince it was returning an invalid path for Julia 1.0-1.2, not sure why though. Locally all tests were passing, but we'll see what travis thinks...Bit of a hack to handle the
iokeyword for Julia below 1.4, alternative suggestions welcome.