Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Recipe: lib4ti2 1.6.9 #1027

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

fingolfin
Copy link
Member

This contains some nasty workarounds for issues with libstdc++.la -- I wonder if these hint at an issue with the build environment? Or perhaps I am doing something stupid? (perhaps @benlorenz has an idea -- but don't feel compelled to look, or waste time on this).

There are a few issues building everything for all platforms, so I may have to disable some. But I thought I should submit this now, even though it is not 100% ready, in the hopes that somebody has feedback on the libstdc++.la problems, and also so that I can show this more easily to people who might be interested in using this (e.g. @mohamed-barakat). And finally perhaps there are other things I should be doing differently here, then it'd be good to hear about it sooner rather than later :-).

@benlorenz
Copy link
Contributor

benlorenz commented May 13, 2020

For the libtool files you can try rm -f ${prefix}/lib/libgmpxx.la instead (always in lib and not $libdir), the file is not really necessary.

Maybe the libtool file should be deleted or adjusted in the gmp package?

@giordano
Copy link
Member

Just remove all libtool archives, they are often wrong:

# Remove misleading libtool files
rm -f ${prefix}/lib/*.la
rm -f /opt/${target}/${target}/lib*/*.la
rm -f /opt/${MACHTYPE}/${MACHTYPE}/lib*/*.la
. We should get rid of them in the RootFS: JuliaPackaging/BinaryBuilder.jl#689

4/4ti2/build_tarballs.jl Outdated Show resolved Hide resolved
4/4ti2/build_tarballs.jl Outdated Show resolved Hide resolved
4/4ti2/build_tarballs.jl Outdated Show resolved Hide resolved
4/4ti2/build_tarballs.jl Outdated Show resolved Hide resolved
@fingolfin fingolfin changed the title New Recipe: 4ti2 1.6.9 (WIP) New Recipe: lib4ti2 1.6.9 (WIP) May 13, 2020
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
@fingolfin
Copy link
Member Author

Thank you all for the very helpful comments!

@fingolfin fingolfin changed the title New Recipe: lib4ti2 1.6.9 (WIP) New Recipe: lib4ti2 1.6.9 May 14, 2020
@giordano giordano merged commit 86324cd into JuliaPackaging:master May 14, 2020
@fingolfin fingolfin deleted the mh/4ti2 branch May 14, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants