Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MKL to 2021.1.1 #2308

Merged
merged 3 commits into from Dec 25, 2020
Merged

Update MKL to 2021.1.1 #2308

merged 3 commits into from Dec 25, 2020

Conversation

ViralBShah
Copy link
Contributor

No description provided.

@ViralBShah ViralBShah marked this pull request as draft December 24, 2020 17:37
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but it seems they once again changed the files structure in the Window package...

@ViralBShah
Copy link
Contributor Author

Looks like the windows now has the same paths for the licenses.

@ViralBShah
Copy link
Contributor Author

What's the reason to make MKL a lazy artifact? Shouldn't we always install it when required?

@giordano
Copy link
Member

Oh yeah, like it was last year: 6c03359. They seem to like moving files back and forth

@giordano
Copy link
Member

What's the reason to make MKL a lazy artifact? Shouldn't we always install it when required?

MKL is proprietary, it's large, it's a dependency of FFTW.jl and it isn't even used by default: JuliaMath/FFTW.jl#133

@ViralBShah
Copy link
Contributor Author

ViralBShah commented Dec 24, 2020

Ah it is an optional dependency there. Makes sense. My thought was that in a package that explicitly depends on MKL, it felt odd to see the download at runtime. For example, SuiteSparse upstream recommends against openblas, and I recently ran into a major performance issue in Circuitscape.jl, which had to be resolved by building SuiteSparse with MKL. That's why I have a renewed interest in MKL.

@ViralBShah
Copy link
Contributor Author

I wonder why it can't find mkl_core. There is a file in the distribution called mkl-core.1.dll. Is it the .1 that is a problem?

[ Info: Found a valid dl path mkl_vml_mc3.1.dll while looking for libmkl_core, mkl_core
[ Info: Could not locate libmkl_core, mkl_core inside ["/agent/_work/1/s/M/MKL/build/x86_64-w64-mingw32/jIJ1g1rr/destdir/bin"]
┌ Error: Built MKL but libmkl_core still unsatisfied:
└ @ BinaryBuilder /depot/packages/BinaryBuilder/57NRU/src/AutoBuild.jl:761
##[error]Built MKL but libmkl_core still unsatisfied:

@giordano
Copy link
Member

Yes, it should be called mkl-core.1:

julia> using Base.BinaryPlatforms

julia> parse_dl_name_version("mkl-core.1.dll", "windows")[1] 
"mkl-core.1"

@ViralBShah ViralBShah marked this pull request as ready for review December 25, 2020 01:51
@ViralBShah ViralBShah merged commit fb96bf5 into master Dec 25, 2020
@ViralBShah ViralBShah deleted the vs/mkl2021 branch December 25, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants