Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenBLAS] add new patch to fix zdot crash #3655

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

inkydragon
Copy link
Contributor

xref: JuliaLang/julia#42397

Things to discuss: Whether the patch needs to be ported to an older version.

@staticfloat
Copy link
Member

Thanks @inkydragon! Can you just try symlinking these patches over into the 0.3.12 directories as well? It sounds like this patch is already present in 0.3.13, so no need to patch there, right?

@inkydragon
Copy link
Contributor Author

Can you just try symlinking these patches over into the 0.3.12 directories as well?

Oh, that was a mistake on my part. I had already confirmed that v0.3.12 did not have this issue when I git bisected it.
40963#issuecomment
The description in JuliaLang/julia#42397 has also been updated.

Now I've made further confirmation.

  • After a quick git checkout test, v0.3.12 already contains this patch.
    git clone https://github.com/xianyi/OpenBLAS.git
    git checkout v0.3.12
    git status
    git cherry-pick b2053239fc3
  • A local build v0.3.12 DLL compiled with Cygwin do not have this issue.
  • Tests on the released v0.3.12 (OpenBLAS_jll.jl-v0.3.12+0) show no bugs

It sounds like this patch is already present in 0.3.13, so no need to patch there, right?

Yes.
You can confirm this by testing the DLL directly. OpenBLAS_jll.jl-v0.3.13+8

inky: Whether the patch needs to be ported to an older version.

What I mean is: do we need to apply patch to versions before 0.3.10. For example 0.3.9.

The ccall test shows:

  • 0.3.5 Works fine
  • 0.3.7 Works fine
  • 0.3.9 Has this issue

@ViralBShah
Copy link
Contributor

We definitely need it for 0.3.10 which is what ships with Julia 1.6 (which is likely to be the new LTS). I wouldn't worry about anything older.

@vchuravy
Copy link
Member

vchuravy commented Oct 1, 2021

Let's land this and we can add it to 0.3.9 when needed

@vchuravy vchuravy merged commit 23aafef into JuliaPackaging:master Oct 1, 2021
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants