Patch PETSc build instead of moving files #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know, the name parsing is in Julia Base, I don't remember the details of the code |
giordano
reviewed
Apr 7, 2022
|
cc: @Wimmerer can you have a look if this makes sense? We will need to rebuild other packages dependning on PETSc_jll but at least we shouldn't need to muck about with patchelf&co. |
vchuravy
changed the title
|
Is this modifying both the filename and SONAME on Linux? Otherwise LGTM (aside from calling from Julia? I assume Julia can handle |
Should be!
Yeah these are all fine. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@giordano is it possible to relax the requirement that the file must end in
dll? If not I will need to fix the petsc build system to not produce files like that.cc: @boriskaus