Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python_jll: Avoid linking to libcrypt.so.1 on glibc systems. #5277

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

maleadt
Copy link
Collaborator

@maleadt maleadt commented Aug 5, 2022

Equivalent of #4879.

Fixes:

ERROR: LoadError: InitError: could not load library "/home/pkgeval/.julia/artifacts/e1a397270be4e889bccc3bed5512d1e0fbac5979/lib/libpython3.8.so"
libcrypt.so.1: cannot open shared object file: No such file or directory
Stacktrace:
  [1] dlopen(s::String, flags::UInt32; throw_error::Bool)
    @ Base.Libc.Libdl ./libdl.jl:117
  [2] dlopen(s::String, flags::UInt32)
    @ Base.Libc.Libdl ./libdl.jl:116
  [3] macro expansion
    @ ~/.julia/packages/JLLWrappers/QpMQW/src/products/library_generators.jl:54 [inlined]
  [4] __init__()
    @ Python_jll ~/.julia/packages/Python_jll/myk8c/src/wrappers/x86_64-linux-gnu.jl:15
  [5] _include_from_serialized(pkg::Base.PkgId, path::String, depmods::Vector{Any})
    @ Base ./loading.jl:831
  [6] _require_search_from_serialized(pkg::Base.PkgId, sourcepath::String, build_id::UInt64)
    @ Base ./loading.jl:1039
  [7] _require(pkg::Base.PkgId)
    @ Base ./loading.jl:1315
  [8] _require_prelocked(uuidkey::Base.PkgId)
    @ Base ./loading.jl:1200
  [9] macro expansion
    @ ./loading.jl:1180 [inlined]
 [10] macro expansion
    @ ./lock.jl:223 [inlined]
 [11] require(into::Module, mod::Symbol)
    @ Base ./loading.jl:1144
 [12] include(mod::Module, _path::String)
    @ Base ./Base.jl:422
 [13] top-level scope
    @ ~/.julia/packages/JLLWrappers/QpMQW/src/toplevel_generators.jl:188
 [14] include
    @ ./Base.jl:422 [inlined]
 [15] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt64}}, source::String)
    @ Base ./loading.jl:1554
 [16] top-level scope
    @ stdin:1
during initialization of module Python_jll

@maleadt maleadt requested a review from giordano August 5, 2022 18:29
@vchuravy vchuravy merged commit 55b3249 into master Aug 5, 2022
@vchuravy vchuravy deleted the tb/python_libcrypt branch August 5, 2022 19:12
@maleadt
Copy link
Collaborator Author

maleadt commented Aug 5, 2022

Hmm, I'm still seeing:

tim@taurus /tmp/lib$ ldd libpython3.8.so
	linux-vdso.so.1 => linux-vdso.so.1 (0x00007ffc8e5cc000)
	libcrypt.so.1 => /usr/lib/libcrypt.so.1 (0x00007ff73c822000)

@giordano Any thoughts?

maleadt added a commit to JuliaCI/PkgEval.jl that referenced this pull request Aug 5, 2022
This ensures compatibility with rr (rr_jll -> GDB_jll -> Python_jll,
which is incompatible with Arch, as noted in
JuliaPackaging/Yggdrasil#5277 (comment)).
@vchuravy
Copy link
Member

vchuravy commented Aug 5, 2022

Mose is on vacation for the next few weeks

eschnett added a commit to eschnett/Yggdrasil that referenced this pull request Aug 8, 2022
* master: (43 commits)
  [SQLite] Update to 3.39.2 (JuliaPackaging#5285)
  Rclone: New version 1.59.0 (JuliaPackaging#5281)
  add FastNoise2 (JuliaPackaging#5284)
  PARMETIS: Support MPItrampoline (JuliaPackaging#5274)
  Add common build script (JuliaPackaging#5286)
  Add ROCmDeviceLibs 4.5.2 (JuliaPackaging#5279)
  Python_jll: Avoid linking to `libcrypt.so.1` on glibc systems. (JuliaPackaging#5277)
  Patch MParT (JuliaPackaging#5254)
  Update GLFW version (JuliaPackaging#5255)
  [protoc] Bump version (JuliaPackaging#5258)
  Add support for mvndst (JuliaPackaging#5275)
  Update iso_codes to 4.11.0 (JuliaPackaging#5276)
  Quantumespresso: Support OpenMPI (JuliaPackaging#5273)
  MSTM: Support MPItrampoline (JuliaPackaging#5168)
  Add ROCm LLVM 4.5.2 (JuliaPackaging#5196)
  PhyML: Enable MPItrampoline (JuliaPackaging#5242)
  TauDEM: Support MPItrampoline (JuliaPackaging#5270)
  TempestModel: Support MPItrampoline (JuliaPackaging#5271)
  [libcxxwrap_julia] Bump version to 0.9.2 (JuliaPackaging#5265)
  SLATE: Support MPItrampoline (JuliaPackaging#5268)
  ...
@giordano
Copy link
Member

giordano commented Aug 31, 2022

The problem is that we use an old glibc, which has a libcrypt.so which is ABI-incompatible with more modern glibcs. I don't have a good solution, apart from waiting the day we'll be able to choose the libc version

Edit: ok, the question was why this still links to libcrypt.so. I don't know, but probably there was something else in the build system pulling it in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants