Update to CoolProp 6.4.3 #6016
Merged
Update to CoolProp 6.4.3 #6016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
first build attempt: fails with |
|
Well, yes, because there is Yggdrasil/C/CoolProp/build_tarballs.jl Line 17 in 85d4be9 |
|
seems that the folder structure changed between releases. now, the build fails with |
|
I guess you'll have to change the name of the directory everywhere it's used |
|
Sorry for that - I did my best to keep things in the same place, but it looks like I failed here. Hope it is not too much extra work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@barche is this alright? i think we have no option in julia but to skip 6.4.2, but thankfully there is now 6.4.3