Update for julia-0.7 #156
Merged
Update for julia-0.7 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I might try to continue from here. |
Various other fixes
This caught some additional deprecations.
This fixes (works around?) `localpart` getting dispatched wrongly on the workers. No idea why.
It has been dropped from Base.
All mapreduce tests passing.
Note: (map)reducedim probably currently falls back to the method for AbstractArray.
This fixes extreme slowness of convert(Array, ::DArray) which was falling back to the generic constructor from AbstractArray.
There was a leftover get from the Nullable times. This should cause an exception, but resulted in a deadlock. Julia bug?
All tests pass without deprecation warnings now.
- update compatibility status - update example code Also, remove superfluous method for mapreduce.
`deepcopy(::DArray)` calls `similar` and deepcopies the localparts. Tests to ensure that `copy` makes a shadllow copy and `deepcopy` makes a deep copy.
indexing and some other cleanup.
|
I think I've now managed to fix all the cases that hit the slow fallbacks and are covered by tests. The tests now set |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes DistributedArrays work on julia 0.7, but compatibility with 0.6 is lost. All tests pass without deprecation warnings.
There are many minor syntax/library changes, and the following major changes:
broadcastimplementation has been rewritten. The basic strategy is to rewrite theBroadcastedobject into its equivalent for the localparts. This will probably only work if all involved arrays are distributed in a "compatible" way. More work is needed to make it fully general.localindexesrenamed tolocalindices, reflecting the current convention in Julia.deepcopy(::DArray)added.importall Basewas removed.Note that there seems to be an obscure issue in Julia which one currently has to work around by calling
using DistributedArrayson the master process before calling@everywhere using DistributedArrays.Calls to
reduceandmapreducewith thedimskeyword (which replace thereducedimandmapreducedimfunctions) are currently slow and I guess some part is falling back to methods forAbstractArray. There is related code insrc/darray.jlwhich is still getting called, but I haven't managed to figure out the call path from theBasemethod.