Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solved a bug for non-conmutative operations between Number and Array. #61

Merged
merged 3 commits into from
Apr 5, 2016
Merged

Solved a bug for non-conmutative operations between Number and Array. #61

merged 3 commits into from
Apr 5, 2016

Conversation

JosmanPS
Copy link
Contributor

@JosmanPS JosmanPS commented Apr 3, 2016

Solved the problem for non-conmutative operations. Resolve #60

@JosmanPS JosmanPS mentioned this pull request Apr 3, 2016
Closed
@tkelman
Copy link
Contributor

tkelman commented Apr 3, 2016

Could you add a test?

@JosmanPS
Copy link
Contributor Author

JosmanPS commented Apr 3, 2016

@tkelman sure.

@JosmanPS
Copy link
Contributor Author

JosmanPS commented Apr 3, 2016

@tkelman Tests are ready!

@JosmanPS
Copy link
Contributor Author

JosmanPS commented Apr 4, 2016

The CI fail is in Julia:nightly, when it's testing the reduce functions.

test DArray reduce
WARNING: Module FactCheck not defined on process 6
fatal error on 6: ERROR: UndefVarError: FactCheck not defined

@andreasnoack
Copy link
Member

I'm looking into this now. It's pretty involved since it is only triggered when inline=no. We could probably merge your PR now but it would be good to have the tests running first.

@andreasnoack
Copy link
Member

See JuliaLang/julia#15766

@andreasnoack andreasnoack reopened this Apr 5, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 67a1359 on JosmanPS:non-conmutative into * on JuliaParallel:master*.

@andreasnoack andreasnoack merged commit 8e0e723 into JuliaParallel:master Apr 5, 2016
@andreasnoack
Copy link
Member

Tests are now passing. Thanks for fixing this bug.

@JosmanPS
Copy link
Contributor Author

JosmanPS commented Apr 5, 2016

Thanks to your team. This package was very helpful for my undergraduate thesis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JosmanPS @tkelman @andreasnoack @coveralls