Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid closures for custom operators #404

Open
simonbyrne opened this issue Jun 30, 2020 · 4 comments · May be fixed by #405
Open

Avoid closures for custom operators #404

simonbyrne opened this issue Jun 30, 2020 · 4 comments · May be fixed by #405
Labels
aarch64 Spectrum MPI

Comments

@simonbyrne
Copy link
Member

To support custom operators for PowerPC and ARM, we will need to avoid using closures as these are not supported (JuliaLang/julia#34326 and JuliaLang/julia#32154). There might be performance advantages on other platforms as well.

We currently skip the relevant tests on these platforms (#353)

Some options:

  • convert Op(f, T=Any) to a generated function
  • write a macro that allows us to "declare" custom operator/type combinations, i.e. 
    @Op f T
    would define a non-closure cfunction for Op(::typeof(f),::Type{T})
simonbyrne added a commit that referenced this issue Jul 7, 2020
@simonbyrne
allow declaration of custom operations at precompilation
21949a1 
Fixes #404.
@simonbyrne simonbyrne linked a pull request Jul 7, 2020 that will close this issue
Open
simonbyrne added a commit that referenced this issue Jul 23, 2020
@simonbyrne
allow declaration of custom operations at precompilation
c4f3fd1 
Fixes #404.
@simonbyrne simonbyrne mentioned this issue Jun 5, 2021
Merged
@sloede sloede mentioned this issue Apr 2, 2022
Draft
4 tasks
@sloede
Copy link
Member

sloede commented Apr 2, 2022

Is there any progress on this issue? I just ran into it on my ARM/M1 laptop and would like to help getting it fixed. Unfortunately, I do not have the necessary chops to go about this alone, but I would be willing to lend a hand, run tests on an M1 etc. if that would be useful.

@giordano
Copy link
Member

May be relevant: https://discourse.julialang.org/t/ann-cclosure-jl-c-closures-like-what-c-does/81234

@giordano giordano mentioned this issue Sep 21, 2022
Draft
This was referenced Feb 27, 2023
Merged
Closed
Closed
@jeffhammond jeffhammond mentioned this issue Feb 1, 2024
Closed
@simonbyrne
Copy link
Member Author

For non-closures, we could use the same approach used by @yuyichao here https://github.com/JuliaMath/GSL.jl/pull/132/files#diff-ed5863a4bdd6189a79314f8c6cb0d3acefa0fe9235e7df221e6686fedb9efc08R40-R48
There is a bit of an explanation on how it works here:
JuliaMath/GSL.jl#130 (comment)

@simonbyrne
Copy link
Member Author

Ah, I don't think that will work.

@ranocha ranocha mentioned this issue Apr 28, 2024
Merged
@sloede sloede mentioned this issue Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aarch64 Spectrum MPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow declaration of custom operations at precompilation JuliaParallel/MPI.jl
3 participants
@giordano @simonbyrne @sloede