-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid closures for custom operators #404
Comments
Is there any progress on this issue? I just ran into it on my ARM/M1 laptop and would like to help getting it fixed. Unfortunately, I do not have the necessary chops to go about this alone, but I would be willing to lend a hand, run tests on an M1 etc. if that would be useful. |
For non-closures, we could use the same approach used by @yuyichao here https://github.com/JuliaMath/GSL.jl/pull/132/files#diff-ed5863a4bdd6189a79314f8c6cb0d3acefa0fe9235e7df221e6686fedb9efc08R40-R48 |
Ah, I don't think that will work. |
To support custom operators for PowerPC and ARM, we will need to avoid using closures as these are not supported (JuliaLang/julia#34326 and JuliaLang/julia#32154). There might be performance advantages on other platforms as well.
We currently skip the relevant tests on these platforms (#353)
Some options:
Op(f, T=Any)
to a generated function@Op f T
cfunction
forOp(::typeof(f),::Type{T})
The text was updated successfully, but these errors were encountered: