Added some docs for TS's options #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 7.23%@@ master #66 diff @@
=======================================
Files 22 22
Lines 21803 21803
Methods 0 0
Branches 0 0
=======================================
Hits 1577 1577
Misses 20226 20226
Partials 0 0
|
|
I'm not sure we should be documenting PETSc options as part of the julia wrappers. Having 2 sets of documentation (Petsc's and ours) makes inconsistencies much more likely. |
|
I added this mostly for consistency with |
|
Sounds good |
|
Better? |
|
Build failure looks unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.