Build system #69
Build system #69
Conversation
Current coverage is 7.11%@@ master #69 diff @@
========================================
Files 22 22
Lines 21803 21804 +1
Methods 0 0
Messages 0 0
Branches 0 0
========================================
- Hits 1637 1551 -86
- Misses 20166 20253 +87
Partials 0 0
|
|
This is a totally minor point, and I'm sure it can be done with the flags to |
|
pinging @stevengj, because IIRC he was working on a patch to PETSc to enable using the Julia OpenBlas build. |
| build_any = false # whether or not to build anything | ||
| have_petsc = Array(Bool, 3) # whether or not each version of Petsc is usable | ||
| for (i, name) in enumerate(build_names) | ||
| if haskey(ENV, string("JULIA_PETSC_", name, "_DIR")) || haskey(ENV, string("JULIA_PETSC_", name, "_ARCH")) |
There was a problem hiding this comment.
It's a good idea to make Pkg.build "remember" these environment variable names, so that if you do Pkg.update() then it will automatically rebuild with the same options unless you explicitly set them.
In PyCall and IJulia, I do this just by saving the relevant env var (PYTHON, in that case) in a file. See https://github.com/stevengj/PyCall.jl/blob/93560fb06affbc02acc237023e1b6a85580b3416/deps/build.jl#L126 and https://github.com/stevengj/PyCall.jl/blob/93560fb06affbc02acc237023e1b6a85580b3416/deps/build.jl#L224-L227
There was a problem hiding this comment.
Added a `buildopts.conf' file to do this.
This updates the build system to allow a couple of things:
configurefor any version of PETSc that is builtThe readme describes what environmental variables to set to do the various operations. All the variables are prefixed with
JULIA_PETSC, which I hope will make them unique.Ref #68 #67 #55