Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace getproperty with getfield #23

Merged
merged 1 commit into from Sep 7, 2018
Merged

replace getproperty with getfield #23

merged 1 commit into from Sep 7, 2018

Conversation

mkborregaard
Copy link
Contributor

because the name in the type has changed

@mkborregaard
replace getproperty with getfield
b91a76f 
because the name in the type has changed
@mkborregaard
Copy link
Contributor Author

Supersedes #21

@mkborregaard mkborregaard mentioned this pull request Sep 7, 2018
Closed
@giordano
Copy link
Member

giordano commented Sep 7, 2018

Thank you!

it's because you don't use the API but reach directly into the internal fields

I'm not sure where this API is documented. I've never found much help for how to test recipes in the docs. Some months ago I asked for help on discourse and got no reply. Probably I ended up with dumping the result of RecipesBase.apply_recipe(Dict{Symbol, Any}(), ...) to see what was in it.

@giordano giordano merged commit 06c17ef into JuliaPhysics:master Sep 7, 2018
@mkborregaard
Copy link
Contributor Author

Sorry to hear that. I like the approach you've taken a lot, actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkborregaard @giordano