Add a pointer to GenericLinearAlgebra.jl #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`using GenericLinearAlgebra` resolves a missing method error for root-finding of `Poly{Measurement{<:Real}}`. It seems like too niche a use case to merit reexporting GenericLinearAlgebra.jl from this package, but those methods are occasionally useful.
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 97.07% 95.50% -1.58%
==========================================
Files 12 12
Lines 547 556 +9
==========================================
Hits 531 531
- Misses 16 25 +9
Continue to review full report at Codecov.
|
giordano
reviewed
Apr 4, 2020
|
Sorry for the late reply! To be honest, I thought I was already mentioning |
|
Can't believe I managed to make a typo in a one-line PR. Thanks for the review! Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using GenericLinearAlgebraresolves a missing method error for root-finding ofPoly{Measurement{<:Real}}. It seems like too niche a use case to merit reexporting GenericLinearAlgebra.jl from this package, but those methods are occasionally useful.