-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods for floatmin/floatmax #72
Conversation
Resolves a missing method error when using Polynomials.jl to curve-fit an array of measurements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I completely missed this pull request!
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 95.50% 95.51% +0.01%
==========================================
Files 12 12
Lines 556 558 +2
==========================================
+ Hits 531 533 +2
Misses 25 25
Continue to review full report at Codecov.
|
@giordano good to merge? |
Yes, thank you so much! |
@giordano can you bump the version to make this available on a release? |
Done, it's in v2.3.0 now! |
I ran into a missing method error when curve-fitting a vector of Measurements using Polynomials.jl:
Fixed with