Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative fix for PGFPlotsX.jl downstream issue #199

Merged

Conversation

Holbormon
Copy link
Contributor

Closes #198.

@BeastyBlacksmith
Copy link
Member

I would prefer to wrap it in @debug than to remove it completely

@Holbormon
Copy link
Contributor Author

Holbormon commented Apr 24, 2024

I would prefer to wrap it in @debug than to remove it completely

Done. Can confirm it fixes the downstream issue KristofferC/PGFPlotsX.jl#325

@BeastyBlacksmith
Copy link
Member

Now we just need to run the tests with debugging enabled to fix CI

@Holbormon
Copy link
Contributor Author

Now we just need to run the tests with debugging enabled to fix CI

Done.

@BeastyBlacksmith
Copy link
Member

Hmm... I thought the difference between the type trees in 1.6 and 1.10 came from the circles in the nodes, but doesn't seem to be the case.
But this accidentally fixes #188 I guess

@BeastyBlacksmith
Copy link
Member

BeastyBlacksmith commented May 6, 2024

For reference:

1.10.2

julia_type_tree1 10

1.6.5

julia_type_tree

@BeastyBlacksmith
Copy link
Member

BeastyBlacksmith commented May 6, 2024

🤦🏻 , so julia 1.6. added a new type... ?

@BeastyBlacksmith BeastyBlacksmith merged commit 9d26211 into JuliaPlots:master May 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debugging variable causes downstream error in PGFPlotsX.jl
2 participants