Fix: adapted grid to work with Number #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply extends the type of the (min, max)-tuple argument for the
adaptive_grid
to acceptNumber
s instead of justReal
s. The goal is to fix jw3126/UnitfulRecipes.jl#36 🙂.For example, with this PR, this MWE
would give
which otherwise currently throws a
on master.
Hopefully, this PR does not break anything since it's a tiny edit! (I have not run tests locally so waiting to see the CI runs... 😁)