Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorbar takes font style from Y Axis #1108

Merged
merged 2 commits into from Oct 5, 2017
Merged

Colorbar takes font style from Y Axis #1108

merged 2 commits into from Oct 5, 2017

Conversation

AnkurD
Copy link

@AnkurD AnkurD commented Sep 26, 2017

Added some examples for different font types
Source Code Pro:
source_code_pro
Noto Sans:
noto_sans
DejaVu Serif
dejavu_serif

@daschw
Copy link
Member

daschw commented Sep 26, 2017

Looks good!
Just FYI: You could have also pushed these changes to the master branch you were using in #1098

Since this PR changes the appearance of some test plots, the tests will probably not pass. The next steps would be to install VisualRegressionTests.jl and clone PlotReferenceImages.jl and run the tests locally (https://juliaplots.github.io/contributing/#testing). For some images (in this case the ones with colorbars) you will be prompted a comparison of the old and the new image, and a dialog asking whether to replace the old image with the new one. If you don't see any regression in the new image you can replace the old one. Once you have replaced the images and the tests pass locally you can add the new images (git add), commit and submit a PR to PlotReferenceImages.jl. In that PR please reference this PR. This will ensure that the Plots tests will pass in future.

This probably sounds a little complicated, so if you need any support, just ask here!

@daschw daschw mentioned this pull request Sep 26, 2017
Copy link
Member

@mkborregaard mkborregaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@AnkurD
Copy link
Author

AnkurD commented Sep 26, 2017

Ah so I did actually make the PR to PlotReferenceImages before I submitted this one, see here: JuliaPlots/PlotReferenceImages.jl#15

@daschw
Copy link
Member

daschw commented Sep 26, 2017

Ok, great, I did not see this.

@mkborregaard
Copy link
Member

@AnkurD would you be willing to have a look at implementing this for GR and PlotlyJS if possible? (I couldn't tell if it would be).

@AnkurD
Copy link
Author

AnkurD commented Sep 26, 2017

I will do my best to implement this for GR and PlotlyJS as well. It might take a couple weeks as I am about to travel, but I'm glad to still help.

@mkborregaard
Copy link
Member

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants