Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marker shapes with segments #2940

Merged
merged 5 commits into from
Aug 31, 2020
Merged

Conversation

daschw
Copy link
Member

@daschw daschw commented Aug 31, 2020

Consider the following code:

using Plots

yv = ones(9)
ys = [1; 1; NaN; ones(6)]

plot(
   5 .- [yv 2ys 3yv 4ys],
   seriestype = [:path :path :scatter :scatter],
   markershape = [:utriangle, :rect],
   markersize = 8,
   color = [:red, :black],
)

Before

This is what we get on master with different backends. No backend behaves as expected for the top series.

GR

marker_segmens_old_gr

PyPlot

marker_segmens_old_pyplot

Plotly

marker_segmens_old_plotlyjs

PGFPlotsX

marker_segmens_old_pgfplotsx

After

This PR fixes this for GR, PyPlot and Plotly. I did not manage to fix it for PGFPlotsX yet.

GR

marker_segmens_new_gr

PyPlot

marker_segmens_new_pyplot

Plotly

marker_segmens_new_plotlyjs

I added above example as a new test example. https://github.com/JuliaPlots/PlotReferenceImages.jl/pull/83is required for the tests to pass.

@daschw
Copy link
Member Author

daschw commented Aug 31, 2020

THis also fixes our broken doc image in http://docs.juliaplots.org/latest/input_data/#columns-are-series

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant