detect aliases in recipes

[BeastyBlacksmith]

Fix #3903

@bencottier could you run your tests on this branch again?

[github-actions]

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

• Time of benchmarks:
  • Target: 28 Oct 2021 - 08:29
  • Baseline: 28 Oct 2021 - 08:31
• Package commits:
  • Target: 5f3678
  • Baseline: 1c621f
• Julia commits:
  • Target: ae8452
  • Baseline: ae8452
• Julia command flags:
  • Target: None
  • Baseline: None
• Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
["display"]	0.00 (5%) ✅	0.00 (1%) ✅
["load_plot_display"]	0.93 (5%) ✅	0.00 (1%) ✅
["plot"]	0.60 (5%) ✅	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• []

Julia versioninfo

Target

Julia Version 1.6.3
Commit ae8452a9e0 (2021-09-23 17:34 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.3 LTS
  uname: Linux 5.8.0-1042-azure #45~20.04.1-Ubuntu SMP Wed Sep 15 14:24:15 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       2191 s          1 s        228 s       1826 s          0 s
       #2  2394 MHz       2337 s          2 s        239 s       1680 s          0 s
       
  Memory: 6.790924072265625 GB (2627.15234375 MB free)
  Uptime: 431.0 sec
  Load Avg:  1.08  1.11  0.59
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, haswell)

Baseline

Julia Version 1.6.3
Commit ae8452a9e0 (2021-09-23 17:34 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.3 LTS
  uname: Linux 5.8.0-1042-azure #45~20.04.1-Ubuntu SMP Wed Sep 15 14:24:15 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       3326 s          1 s        246 s       1979 s          0 s
       #2  2394 MHz       2502 s          2 s        249 s       2808 s          0 s
       
  Memory: 6.790924072265625 GB (2641.87890625 MB free)
  Uptime: 562.0 sec
  Load Avg:  1.01  1.07  0.65
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, haswell)

---

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

• Time of benchmark: 28 Oct 2021 - 8:29
• Package commit: 5f3678
• Julia commit: ae8452
• Julia command flags: None
• Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
["display"]	13.482 ms (5%)		3.62 MiB (1%)	192005
["load"]	6.395 s (5%)		3.55 KiB (1%)	75
["load_plot_display"]	19.710 s (5%)		3.59 KiB (1%)	75
["plot"]	709.308 μs (5%)		74.40 KiB (1%)	1105

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• []

Julia versioninfo

Julia Version 1.6.3
Commit ae8452a9e0 (2021-09-23 17:34 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.3 LTS
  uname: Linux 5.8.0-1042-azure #45~20.04.1-Ubuntu SMP Wed Sep 15 14:24:15 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       2191 s          1 s        228 s       1826 s          0 s
       #2  2394 MHz       2337 s          2 s        239 s       1680 s          0 s
       
  Memory: 6.790924072265625 GB (2627.15234375 MB free)
  Uptime: 431.0 sec
  Load Avg:  1.08  1.11  0.59
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, haswell)

---

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

• Time of benchmark: 28 Oct 2021 - 8:31
• Package commit: 1c621f
• Julia commit: ae8452
• Julia command flags: None
• Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
["display"]	9.947 s (5%)	317.404 ms	846.33 MiB (1%)	14989212
["load"]	6.430 s (5%)		3.55 KiB (1%)	75
["load_plot_display"]	21.253 s (5%)		22.71 MiB (1%)	388705
["plot"]	1.181 ms (5%)		74.40 KiB (1%)	1105

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• []

Julia versioninfo

Julia Version 1.6.3
Commit ae8452a9e0 (2021-09-23 17:34 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.3 LTS
  uname: Linux 5.8.0-1042-azure #45~20.04.1-Ubuntu SMP Wed Sep 15 14:24:15 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       3326 s          1 s        246 s       1979 s          0 s
       #2  2394 MHz       2502 s          2 s        249 s       2808 s          0 s
       
  Memory: 6.790924072265625 GB (2641.87890625 MB free)
  Uptime: 562.0 sec
  Load Avg:  1.01  1.07  0.65
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, haswell)

---

Runtime information

Runtime Info
BLAS #threads	2
BLAS.vendor()	openblas64
Sys.CPU_THREADS	2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           63
Model name:                      Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Stepping:                        2
CPU MHz:                         2394.454
BogoMIPS:                        4788.90
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        512 KiB
L3 cache:                        30 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Vendor	:Intel
Architecture	:Haswell
Model	Family: 0x06, Model: 0x3f, Stepping: 0x02, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 256, 30720) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 46 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via rdtsc
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

[codecov]

Codecov Report

Merging #3904 (82ddce5) into master (e835696) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3904      +/-   ##
==========================================
+ Coverage   62.68%   62.75%   +0.07%     
==========================================
  Files          29       29              
  Lines        7570     7563       -7     
==========================================
+ Hits         4745     4746       +1     
+ Misses       2825     2817       -8     

Impacted Files	Coverage Δ
src/pipeline.jl	94.27% <100.00%> (+3.67%)	⬆️
src/args.jl	72.38% <0.00%> (-0.15%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c621fe...82ddce5. Read the comment docs.

[github-actions]

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

• Time of benchmarks:
  • Target: 28 Oct 2021 - 08:36
  • Baseline: 28 Oct 2021 - 08:38
• Package commits:
  • Target: ed9a99
  • Baseline: 1c621f
• Julia commits:
  • Target: ae8452
  • Baseline: ae8452
• Julia command flags:
  • Target: None
  • Baseline: None
• Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
["display"]	0.00 (5%) ✅	0.00 (1%) ✅
["load_plot_display"]	0.99 (5%)	0.00 (1%) ✅
["plot"]	0.51 (5%) ✅	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• []

Julia versioninfo

Target

Julia Version 1.6.3
Commit ae8452a9e0 (2021-09-23 17:34 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.3 LTS
  uname: Linux 5.8.0-1042-azure #45~20.04.1-Ubuntu SMP Wed Sep 15 14:24:15 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       1802 s          1 s        216 s       2096 s          0 s
       #2  2294 MHz       2689 s          1 s        278 s       1190 s          0 s
       
  Memory: 6.790924072265625 GB (2670.69921875 MB free)
  Uptime: 421.0 sec
  Load Avg:  1.1  1.06  0.57
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.6.3
Commit ae8452a9e0 (2021-09-23 17:34 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.3 LTS
  uname: Linux 5.8.0-1042-azure #45~20.04.1-Ubuntu SMP Wed Sep 15 14:24:15 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       2483 s          1 s        232 s       2719 s          0 s
       #2  2294 MHz       3323 s          1 s        292 s       1862 s          0 s
       
  Memory: 6.790924072265625 GB (2656.07421875 MB free)
  Uptime: 553.0 sec
  Load Avg:  1.01  1.04  0.63
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, broadwell)

---

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

• Time of benchmark: 28 Oct 2021 - 8:36
• Package commit: ed9a99
• Julia commit: ae8452
• Julia command flags: None
• Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
["display"]	13.838 ms (5%)		3.62 MiB (1%)	192005
["load"]	6.634 s (5%)		3.55 KiB (1%)	75
["load_plot_display"]	20.592 s (5%)		3.59 KiB (1%)	75
["plot"]	732.405 μs (5%)		74.40 KiB (1%)	1105

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• []

Julia versioninfo

Julia Version 1.6.3
Commit ae8452a9e0 (2021-09-23 17:34 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.3 LTS
  uname: Linux 5.8.0-1042-azure #45~20.04.1-Ubuntu SMP Wed Sep 15 14:24:15 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       1802 s          1 s        216 s       2096 s          0 s
       #2  2294 MHz       2689 s          1 s        278 s       1190 s          0 s
       
  Memory: 6.790924072265625 GB (2670.69921875 MB free)
  Uptime: 421.0 sec
  Load Avg:  1.1  1.06  0.57
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, broadwell)

---

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

• Time of benchmark: 28 Oct 2021 - 8:38
• Package commit: 1c621f
• Julia commit: ae8452
• Julia command flags: None
• Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
["display"]	10.580 s (5%)	364.941 ms	967.53 MiB (1%)	17295778
["load"]	6.332 s (5%)		3.55 KiB (1%)	75
["load_plot_display"]	20.897 s (5%)		22.71 MiB (1%)	388707
["plot"]	1.430 ms (5%)		74.40 KiB (1%)	1105

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• []

Julia versioninfo

Julia Version 1.6.3
Commit ae8452a9e0 (2021-09-23 17:34 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.3 LTS
  uname: Linux 5.8.0-1042-azure #45~20.04.1-Ubuntu SMP Wed Sep 15 14:24:15 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       2483 s          1 s        232 s       2719 s          0 s
       #2  2294 MHz       3323 s          1 s        292 s       1862 s          0 s
       
  Memory: 6.790924072265625 GB (2656.07421875 MB free)
  Uptime: 553.0 sec
  Load Avg:  1.01  1.04  0.63
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, broadwell)

---

Runtime information

Runtime Info
BLAS #threads	2
BLAS.vendor()	openblas64
Sys.CPU_THREADS	2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           79
Model name:                      Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping:                        1
CPU MHz:                         2294.684
BogoMIPS:                        4589.36
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        512 KiB
L3 cache:                        50 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Full generic retpoline, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor	:Intel
Architecture	:Broadwell
Model	Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 256, 51200) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 46 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via rdtsc
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

[bencottier]

Thanks for this!

Our internal package tests still fail because it accesses internals of Plots.jl, like result.subplots[1][:legend]. But that's our problem for accessing internals (the reason is to test that plotting kwargs from a function are correctly passed on to the plot).

If I change our tests to use result.subplots[1][:legend_position], then this branch fixes #3903 in our tests.

[BeastyBlacksmith]

But that's our problem for accessing internals

Well, you wouldn't need to, if we had an API for that ^^, but thanks for checking. I'll merge and make a release.