Fix setting of legend font via legend_font
#3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3934 +/- ##
==========================================
- Coverage 62.80% 62.50% -0.31%
==========================================
Files 29 29
Lines 7587 7270 -317
==========================================
- Hits 4765 4544 -221
+ Misses 2822 2726 -96
Continue to review full report at Codecov.
|
isentropic
pushed a commit
to isentropic/Plots.jl
that referenced
this pull request
Jan 16, 2022
* find pipeline spot * better spot * construct font * set font and matching * respect defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on slack (https://julialang.slack.com/archives/C6E4SU1D3/p1636254485054400) #2854 broke setting the legend font via
plot(1:5, legendfont = font(8))Furthermore this makes
sp[:legend_font]the single point of truth for the legend font properties, since having bothsp[:legend_font]and e.g.sp[:legend_font_color]is a bit dangerous since they can get out of sync pretty easily especially with property matching and so forth.. In the future we should remove them entirely from the subplot attributes.