rework layout macro to use Base types #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3943 +/- ##
==========================================
- Coverage 62.56% 62.43% -0.13%
==========================================
Files 29 29
Lines 7268 7223 -45
==========================================
- Hits 4547 4510 -37
+ Misses 2721 2713 -8
Continue to review full report at Codecov.
|
|
Here is a case, that currently gives different results: using Plots
plot(rand(100, 6), layout = @layout([_ ° _; ° ° °; ° ° °]), title = ["A" "B" "C"])Master
PR
|
|
Tests need JuliaPlots/RecipesBase.jl#85 to pass |
isentropic
pushed a commit
to isentropic/Plots.jl
that referenced
this pull request
Jan 16, 2022
* @layout -> Base types except for `grid` call * add layout conversion of namedtuples, vectors and matrices * add missing method * rip it out * fix slicing * adjust compat * add Measure conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should enable users to use the
@layoutmacro in recipes.Currently this seems to work fine, except for the case of
gridcalls in the argument expression. Which is hardly documented and I am consideringremoving this optionleaving things as they are, since it is usable while having Plots loaded and you can't use that in recipes either way.Fix JuliaPlots/RecipesBase.jl#15