gr-constant-legendbox #4043
Merged
gr-constant-legendbox #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At some point, I got to image comparison, but I could never click on 'yes' to accept the ref image on GUI yes/no popup :( I'm just bad at testing |
|
FWIW, I can reproduce the dialog hanging on the follwing system: julia> versioninfo()
Julia Version 1.7.0
Commit 3bf9d17731 (2021-11-30 12:12 UTC)
Platform Info:
OS: Linux (x86_64-pc-linux-gnu)
CPU: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-12.0.1 (ORCJIT, tigerlake) |
If this is blocking you, can delete the reference file, and it will be regenerated without |
|
So after a few hours of struggle with test I give up, this popup is borked for sure. Something somewhere in https://github.com/JuliaPlots/VisualRegressionTests.jl needs fixing. Also plotly tests fail half the time due to this Our test suite really needs some work. |
|
To avoid the popup (when |
|
Will the reference images update in this case or the tests just fail? |
|
I think the test will fail unless you delete the reference image by hand first (no tested though). |
|
I'm tryign |
|
Oh, ==> you should use |
|
The tests are stuck at |
|
Try exporting the See also Plots.jl/.github/workflows/ci.yml Line 18 in 1f49839 |
|
Setting the GKSwstype "100" helps that I do see kvantum warning anymore, now I cannot press the GUI popup, so its stuck. I do not think deleting images one by one and rerunning the test suite is a viable solution in the long term. Does the GUI hang for you too? I can't understand what's causing it (feeling helpless) |
|
I'm most certain this is OS dependent (linux user here). What OS and julia version are you on ? |
Try entering |
|
I'm on gnome Manjaro, running 1.6.5 Julia. Terminal is just stuck, I gotta kill it via C-c |
|
@BeastyBlacksmith Simon confirmed the GUI problem |
|
See also Line 87 in 1f49839 Using |
|
@BeastyBlacksmith I might have fixed this issue in JuliaPlots/VisualRegressionTests.jl@a1f57f4 solution taken from this thread https://discourse.julialang.org/t/problem-with-gui-ask-dialog/73224/21 |
|
Do you mind checking commit and verifying that it no longer hangs? A good way is to change one of the filenames in the tests of VisualRegressionTests to prompt the GUI |
|
Finally I did it |
|
@BeastyBlacksmith should I merge at the same time or something has prioiryt? |
|
you need to merge the reference images before and then retrigger CI on this PR |
isentropic
added a commit
that referenced
this pull request
Jan 21, 2022
This reverts commit 806e769.
isentropic
added a commit
that referenced
this pull request
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BeastyBlacksmith @daschw I tried a few times more, but I consistently get stuck at plotly part of the tests, so I still could not push the relevant RefImages...