Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format check #4053

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Add format check #4053

merged 1 commit into from
Jan 22, 2022

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jan 21, 2022

Add a formatting check action.

Rationale:

  • avoid polluting git history with format PRs, developers should be advised to run using JuliaFormatter; format(["src", "test"]) before the PR is merged.
  • keep the format PR action in case some unformatted changes slip through, only run it less often (monthly instead of weekly).

@t-bltg t-bltg added the CI continuous integration label Jan 21, 2022
@t-bltg t-bltg force-pushed the fmt_check branch 2 times, most recently from 04da481 to 71ba6ca Compare January 21, 2022 10:36
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #4053 (61c05e1) into master (f333cb2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4053      +/-   ##
==========================================
- Coverage   62.13%   62.11%   -0.02%     
==========================================
  Files          29       29              
  Lines        7286     7286              
==========================================
- Hits         4527     4526       -1     
- Misses       2759     2760       +1     
Impacted Files Coverage Δ
src/backends/unicodeplots.jl 51.06% <0.00%> (ø)
src/types.jl 47.82% <0.00%> (-4.35%) ⬇️
src/backends/gr.jl 88.27% <0.00%> (-0.09%) ⬇️
src/recipes.jl 58.60% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd9873...61c05e1. Read the comment docs.

@t-bltg t-bltg force-pushed the fmt_check branch 2 times, most recently from 137eed6 to 71abc49 Compare January 21, 2022 10:41
@t-bltg t-bltg merged commit ab698da into JuliaPlots:master Jan 22, 2022
@t-bltg t-bltg deleted the fmt_check branch January 23, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant