-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example for vspan and hspan #4062
Conversation
Looks like I would need to add a new image to https://github.com/JuliaPlots/PlotReferenceImages.jl — what's the usual workflow for doing a PR like this? I'm happy to make a PR there now if we're happy with the example, which generates the following: |
https://docs.juliaplots.org/latest/contributing/#VisualRegressionTests |
I've opened a PR on PlotReferenceImages.jl — but that PR will obviously need tweaking if anyone would like the example tweaked :) |
Looks good. |
Also as a first time contributor check out #3503 and consider adding your information to our |
Codecov Report
@@ Coverage Diff @@
## master #4062 +/- ##
==========================================
+ Coverage 62.14% 62.16% +0.01%
==========================================
Files 29 29
Lines 7288 7289 +1
==========================================
+ Hits 4529 4531 +2
+ Misses 2759 2758 -1
Continue to review full report at Codecov.
|
Closes #4051.
Provide example of using vspan and hspan.