Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for vspan and hspan #4062

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Example for vspan and hspan #4062

merged 3 commits into from
Jan 26, 2022

Conversation

tpgillam
Copy link
Contributor

Closes #4051.

Provide example of using vspan and hspan.

@tpgillam
Copy link
Contributor Author

Looks like I would need to add a new image to https://github.com/JuliaPlots/PlotReferenceImages.jl — what's the usual workflow for doing a PR like this? I'm happy to make a PR there now if we're happy with the example, which generates the following:
ref57

@t-bltg
Copy link
Member

t-bltg commented Jan 24, 2022

what's the usual workflow for doing a PR like this?

https://docs.juliaplots.org/latest/contributing/#VisualRegressionTests

@tpgillam
Copy link
Contributor Author

I've opened a PR on PlotReferenceImages.jl — but that PR will obviously need tweaking if anyone would like the example tweaked :)

@t-bltg
Copy link
Member

t-bltg commented Jan 24, 2022

Looks good.
Please format your pr using $ julia -e 'using JuliaFormatter; format(["src", "test"])' in your Plots.jl fork.

@BeastyBlacksmith
Copy link
Member

Also as a first time contributor check out #3503 and consider adding your information to our .zenodo.json file

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #4062 (bca0eb9) into master (311831c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4062      +/-   ##
==========================================
+ Coverage   62.14%   62.16%   +0.01%     
==========================================
  Files          29       29              
  Lines        7288     7289       +1     
==========================================
+ Hits         4529     4531       +2     
+ Misses       2759     2758       -1     
Impacted Files Coverage Δ
src/examples.jl 61.76% <ø> (ø)
src/recipes.jl 58.49% <0.00%> (-0.12%) ⬇️
src/backends/gr.jl 88.27% <0.00%> (-0.09%) ⬇️
src/utils.jl 49.92% <0.00%> (+0.15%) ⬆️
src/pipeline.jl 94.24% <0.00%> (+0.47%) ⬆️
src/types.jl 52.17% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311831c...bca0eb9. Read the comment docs.

@BeastyBlacksmith BeastyBlacksmith merged commit 5d52398 into JuliaPlots:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Filling horizontal regions across whole vertical axis range
3 participants