Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plotattributes in _add_plot_title! #4090

Merged
merged 5 commits into from
Feb 7, 2022
Merged

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Feb 3, 2022

Fix #4083.

@t-bltg t-bltg added GR bug and removed GR labels Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #4090 (0d708d0) into master (6e4cb5f) will decrease coverage by 0.01%.
The diff coverage is 74.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4090      +/-   ##
==========================================
- Coverage   62.25%   62.23%   -0.02%     
==========================================
  Files          29       29              
  Lines        7293     7304      +11     
==========================================
+ Hits         4540     4546       +6     
- Misses       2753     2758       +5     
Impacted Files Coverage Δ
src/args.jl 72.45% <ø> (ø)
src/backends.jl 64.60% <ø> (ø)
src/examples.jl 63.63% <ø> (ø)
src/backends/unicodeplots.jl 53.16% <69.56%> (-0.22%) ⬇️
src/pipeline.jl 94.27% <100.00%> (+0.02%) ⬆️
src/plot.jl 67.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce70ec2...0d708d0. Read the comment docs.

Copy link
Member

@BeastyBlacksmith BeastyBlacksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a bit heavy handed

Co-authored-by: Simon Christ <SimonChrist@gmx.de>
@t-bltg
Copy link
Member Author

t-bltg commented Feb 6, 2022

Thats a bit heavy handed

? Is there an alternative ?

src/plot.jl Outdated Show resolved Hide resolved
Copy link
Member

@BeastyBlacksmith BeastyBlacksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that better :)

@t-bltg t-bltg merged commit bf5d1aa into JuliaPlots:master Feb 7, 2022
@t-bltg t-bltg deleted the ttl_frame branch February 7, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] plot_title with framestyle shows subplot of title
2 participants