Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module eval (example 41) #4093

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Fix module eval (example 41) #4093

merged 1 commit into from
Feb 6, 2022

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Feb 3, 2022

Fixes the following

julia> using Plots
julia> Plots.test_examples(:unicodeplots, 41, disp=true)
ERROR: LoadError: type IdOffsetRange has no field stop
Stacktrace:
  [1] getproperty(x::OffsetArrays.IdOffsetRange{Int64, Base.OneTo{Int64}}, f::Symbol)
    @ Base ./Base.jl:33
  [2] last(r::OffsetArrays.IdOffsetRange{Int64, Base.OneTo{Int64}})
    @ Base ./range.jl:613
  [3] length
    @ ./range.jl:586 [inlined]
  [4] size(r::OffsetArrays.IdOffsetRange{Int64, Base.OneTo{Int64}})
    @ Base ./range.jl:515
  [5] axes
    @ ./abstractarray.jl:89 [inlined]
  [6] similar(a::OffsetArrays.IdOffsetRange{Int64, Base.OneTo{Int64}}, #unused#::Type{Float64})
    @ Base ./abstractarray.jl:739
  [7] AbstractVector{Float64}(A::OffsetArrays.IdOffsetRange{Int64, Base.OneTo{Int64}})
    @ Base ./array.jl:541
  [8] (AbstractArray{Float64, N} where N)(A::OffsetArrays.IdOffsetRange{Int64, Base.OneTo{Int64}})
    @ Core ./boot.jl:475
  [9] convert(#unused#::Type{AbstractArray{Float64, N} where N}, a::OffsetArrays.IdOffsetRange{Int64, Base.OneTo{Int64}})
    @ Base ./abstractarray.jl:15
 [10] float(A::OffsetArrays.IdOffsetRange{Int64, Base.OneTo{Int64}})
    @ Base ./float.jl:896
[...]

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #4093 (bda951e) into master (2a7d2d7) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4093      +/-   ##
==========================================
+ Coverage   62.22%   62.23%   +0.01%     
==========================================
  Files          29       29              
  Lines        7295     7293       -2     
==========================================
  Hits         4539     4539              
+ Misses       2756     2754       -2     
Impacted Files Coverage Δ
src/examples.jl 63.63% <0.00%> (+1.87%) ⬆️
src/backends/gr.jl 88.27% <0.00%> (-0.09%) ⬇️
src/types.jl 52.17% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7d2d7...bda951e. Read the comment docs.

@t-bltg t-bltg merged commit 6e4cb5f into JuliaPlots:master Feb 6, 2022
@t-bltg t-bltg deleted the fix_41 branch February 13, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants