-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compat entries for backends #4122
Conversation
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Plots.jl/Plots.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Codecov Report
@@ Coverage Diff @@
## master #4122 +/- ##
==========================================
- Coverage 62.40% 62.36% -0.05%
==========================================
Files 29 29
Lines 7301 7301
==========================================
- Hits 4556 4553 -3
- Misses 2745 2748 +3
Continue to review full report at Codecov.
|
@t-bltg you should know best, what the lower bound for Unicode plots is these days |
The current mentioned version ( Regarding this PR, I guess some user won't be happy about added dependencies (especially, if I remember about |
We don't actually add the dependencies. They are added to the |
Ha sorry, I misread the changes. I'm not very familiar with the |
This adds compat entries for PyPlot, PGFPlotsX, PlotlyJS and PlotlyBase.
Actually a reaction to #4105, since we can then tag a version that requires PlotlyBase 0.7 and make a version that is compatible with 0.8.
The pitfall here is that people will complain if their dependencies get hold back by compat requirements of a backend that they don't use.