adjust is3d for gr #4241

BeastyBlacksmith · 2022-06-16T17:00:21Z

This doesn't work yet, but potentially

Fix #4240

github-actions · 2022-06-16T17:16:11Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmarks:
- Target: 16 Jun 2022 - 17:14
- Baseline: 16 Jun 2022 - 17:15
Package commits:
- Target: a9f569
- Baseline: d84290
Julia commits:
- Target: 742b9a
- Baseline: 742b9a
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["display"]`	0.00 (5%) ✅	0.00 (1%) ✅
`["load_plot_display"]`	0.94 (5%) ✅	0.00 (1%) ✅
`["plot"]`	0.79 (5%) ✅	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Target

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1029-azure #34~20.04.1-Ubuntu SMP Thu Jun 9 12:37:07 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1770 s          0 s        200 s       1429 s          0 s
       #2  2593 MHz       1685 s          0 s        225 s       1511 s          0 s
       
  Memory: 6.783603668212891 GB (2730.76953125 MB free)
  Uptime: 345.67 sec
  Load Avg:  1.14  1.07  0.53
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1029-azure #34~20.04.1-Ubuntu SMP Thu Jun 9 12:37:07 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       2421 s          0 s        213 s       1699 s          0 s
       #2  2593 MHz       1952 s          0 s        236 s       2166 s          0 s
       
  Memory: 6.783603668212891 GB (2724.5703125 MB free)
  Uptime: 439.18 sec
  Load Avg:  1.04  1.06  0.58
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmark: 16 Jun 2022 - 17:14
Package commit: a9f569
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	memory	allocations
`["display"]`	3.941 ms (5%)	246.20 KiB (1%)	4514
`["load"]`	5.411 s (5%)	3.16 KiB (1%)	74
`["load_plot_display"]`	14.964 s (5%)	3.50 KiB (1%)	75
`["plot"]`	604.908 μs (5%)	76.96 KiB (1%)	1363

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1029-azure #34~20.04.1-Ubuntu SMP Thu Jun 9 12:37:07 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1770 s          0 s        200 s       1429 s          0 s
       #2  2593 MHz       1685 s          0 s        225 s       1511 s          0 s
       
  Memory: 6.783603668212891 GB (2730.76953125 MB free)
  Uptime: 345.67 sec
  Load Avg:  1.14  1.07  0.53
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmark: 16 Jun 2022 - 17:15
Package commit: d84290
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["display"]`	6.467 s (5%)	182.323 ms	497.07 MiB (1%)	9318947
`["load"]`	5.468 s (5%)		3.16 KiB (1%)	74
`["load_plot_display"]`	15.879 s (5%)	12.631 ms	22.65 MiB (1%)	425434
`["plot"]`	769.710 μs (5%)		76.96 KiB (1%)	1363

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1029-azure #34~20.04.1-Ubuntu SMP Thu Jun 9 12:37:07 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       2421 s          0 s        213 s       1699 s          0 s
       #2  2593 MHz       1952 s          0 s        236 s       2166 s          0 s
       
  Memory: 6.783603668212891 GB (2724.5703125 MB free)
  Uptime: 439.18 sec
  Load Avg:  1.04  1.06  0.58
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           85
Model name:                      Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Stepping:                        7
CPU MHz:                         2593.907
BogoMIPS:                        5187.81
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        2 MiB
L3 cache:                        35.8 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor	:Intel
Architecture	:Skylake
Model	Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 1024, 36608) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 46 bits physical
SIMD	512 bit = 64 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

codecov · 2022-06-16T17:35:28Z

Codecov Report

Merging #4241 (b5a21d6) into master (d842903) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4241      +/-   ##
==========================================
+ Coverage   77.86%   77.88%   +0.01%     
==========================================
  Files          28       28              
  Lines        7112     7116       +4     
==========================================
+ Hits         5538     5542       +4     
  Misses       1574     1574

Impacted Files	Coverage Δ
src/backends/gr.jl	`89.06% <100.00%> (+0.03%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d842903...b5a21d6. Read the comment docs.

github-actions · 2022-06-17T05:59:16Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmarks:
- Target: 17 Jun 2022 - 05:57
- Baseline: 17 Jun 2022 - 05:59
Package commits:
- Target: 693fa0
- Baseline: d84290
Julia commits:
- Target: 742b9a
- Baseline: 742b9a
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["display"]`	0.00 (5%) ✅	0.00 (1%) ✅
`["load"]`	1.09 (5%) ❌	1.00 (1%)
`["load_plot_display"]`	1.05 (5%) ❌	0.00 (1%) ✅
`["plot"]`	0.86 (5%) ✅	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Target

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1029-azure #34~20.04.1-Ubuntu SMP Thu Jun 9 12:37:07 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1665 s          1 s        202 s       3089 s          0 s
       #2  2593 MHz       1778 s          1 s        220 s       2992 s          0 s
       
  Memory: 6.783603668212891 GB (2673.06640625 MB free)
  Uptime: 504.24 sec
  Load Avg:  1.05  0.94  0.47
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1029-azure #34~20.04.1-Ubuntu SMP Thu Jun 9 12:37:07 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1921 s          1 s        213 s       3720 s          0 s
       #2  2593 MHz       2406 s          1 s        230 s       3253 s          0 s
       
  Memory: 6.783603668212891 GB (2699.87890625 MB free)
  Uptime: 594.25 sec
  Load Avg:  1.01  0.96  0.52
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmark: 17 Jun 2022 - 5:57
Package commit: 693fa0
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	memory	allocations
`["display"]`	3.944 ms (5%)	246.20 KiB (1%)	4514
`["load"]`	5.441 s (5%)	3.16 KiB (1%)	74
`["load_plot_display"]`	14.916 s (5%)	3.50 KiB (1%)	75
`["plot"]`	627.509 μs (5%)	76.96 KiB (1%)	1363

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1029-azure #34~20.04.1-Ubuntu SMP Thu Jun 9 12:37:07 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1665 s          1 s        202 s       3089 s          0 s
       #2  2593 MHz       1778 s          1 s        220 s       2992 s          0 s
       
  Memory: 6.783603668212891 GB (2673.06640625 MB free)
  Uptime: 504.24 sec
  Load Avg:  1.05  0.94  0.47
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmark: 17 Jun 2022 - 5:59
Package commit: d84290
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["display"]`	5.813 s (5%)	226.406 ms	497.05 MiB (1%)	9318744
`["load"]`	4.977 s (5%)		3.16 KiB (1%)	74
`["load_plot_display"]`	14.142 s (5%)	14.239 ms	22.67 MiB (1%)	425439
`["plot"]`	731.411 μs (5%)		76.96 KiB (1%)	1363

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1029-azure #34~20.04.1-Ubuntu SMP Thu Jun 9 12:37:07 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1921 s          1 s        213 s       3720 s          0 s
       #2  2593 MHz       2406 s          1 s        230 s       3253 s          0 s
       
  Memory: 6.783603668212891 GB (2699.87890625 MB free)
  Uptime: 594.25 sec
  Load Avg:  1.01  0.96  0.52
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           85
Model name:                      Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Stepping:                        7
CPU MHz:                         2593.905
BogoMIPS:                        5187.81
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        2 MiB
L3 cache:                        35.8 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor	:Intel
Architecture	:Skylake
Model	Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 1024, 36608) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 46 bits physical
SIMD	512 bit = 64 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

adjust is3d for gr

3461e6d

BeastyBlacksmith marked this pull request as draft June 16, 2022 17:04

prevent stackoverflow

3410acb

gr: reset projection for contours/heatmaps

b5a21d6

jheinen marked this pull request as ready for review June 17, 2022 05:53

jheinen mentioned this pull request Jun 17, 2022

surface and then contour scrambles the result #4240

Closed

jheinen merged commit 582bc72 into master Jun 17, 2022

BeastyBlacksmith deleted the bbs/fix-gr-is3d branch March 15, 2023 08:34

adjust is3d for gr #4241

adjust is3d for gr #4241

Conversation

BeastyBlacksmith commented Jun 16, 2022 • edited

github-actions bot commented Jun 16, 2022

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

codecov bot commented Jun 16, 2022 • edited

Codecov Report

github-actions bot commented Jun 17, 2022

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

BeastyBlacksmith commented Jun 16, 2022 •

edited

codecov bot commented Jun 16, 2022 •

edited