-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PGFPlotsX: reworks #4262
PGFPlotsX: reworks #4262
Conversation
709dd3d
to
0aee0a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4262 +/- ##
==========================================
+ Coverage 79.67% 79.91% +0.24%
==========================================
Files 29 29
Lines 7052 6962 -90
==========================================
- Hits 5619 5564 -55
+ Misses 1433 1398 -35
Continue to review full report at Codecov.
|
9d7b788
to
cceac5d
Compare
can you split the functional and the aestetics part of this PR into two PRs? |
I've rebased the whole PR into multiple commits, so it can be more easily reviewed. I've added more tests for I've also fixed the |
02ccebc
to
6c489c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am reckognizing that code format is a highly opinionated topic, but some changes here (that I marked with ^
) are reducing readability and maintainability in favor of terseness.
In general I try to write code in a way that there is mostly happening one thing at a time on one line and that you have to change few things if you need to extend or refactor the code.
Thanks for the review. I've tried to answer all the comments, explained why some are IMO justified and rebased the PR to remove the modifications on which we agreed are unjustified or not needed. |
afc2039
to
d98e635
Compare
6f20e7f
to
dcee6db
Compare
I am going to merge the PR when CI passes, unless something new is brought to the table. |
fix Unicode error with PGFPlotsX [BUG] #3219;
fix [BUG] LaTeX error in PGFPlotsX backend. #4182;
rework
aspect_ratio
after forward aspect ratio for 3D plots in pgfplotsx #4231 (comment);lots of code simplifications (consistency, modernization) - remove ~140 lines.
build docs => no apparent regression
Needs korsbo/Latexify.jl#223.