Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use withenv instead of persistent ENV variables #4402

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Sep 30, 2022

Leaving persistent ENV variables is a bad habbit.
If we really need those set because of the way GR works by design, we should clear them after usage.

@t-bltg t-bltg added enhancement improving existing functionality GR labels Sep 30, 2022
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 80.84% // Head: 80.87% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (0ebf099) compared to base (c7e3191).
Patch coverage: 58.82% of modified lines in pull request are covered.

❗ Current head 0ebf099 differs from pull request most recent head 9c2f000. Consider uploading reports for the commit 9c2f000 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4402      +/-   ##
==========================================
+ Coverage   80.84%   80.87%   +0.03%     
==========================================
  Files          30       30              
  Lines        7448     7445       -3     
==========================================
  Hits         6021     6021              
+ Misses       1427     1424       -3     
Impacted Files Coverage Δ
src/backends/gr.jl 89.30% <58.82%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t-bltg
Copy link
Member Author

t-bltg commented Sep 30, 2022

Windows 1.8 failure is unrelated.

@t-bltg t-bltg merged commit 8a6acf8 into JuliaPlots:master Sep 30, 2022
@t-bltg t-bltg deleted the withenv branch September 30, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing functionality GR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant