-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gr
: support horizontal legends
#4496
Conversation
ca1faba
to
ee8a5c3
Compare
17dbcbc
to
787d99a
Compare
Codecov ReportBase: 90.88% // Head: 90.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4496 +/- ##
==========================================
- Coverage 90.88% 90.64% -0.25%
==========================================
Files 40 40
Lines 7650 7354 -296
==========================================
- Hits 6953 6666 -287
+ Misses 697 688 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@BeastyBlacksmith, I've updated all the images in this PR, and I think we have the correct behavior in terms of positioning and symmetry. Do you have any more comments, before this goes in (pending I am going to make it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this :)
Fix #2206.
Fix #4497 (and add regression tests).
It's a tough one since the
gr
code is a mess, non generic, easily breakable (some legend code paths are not tested in ref imgs), etc...Add the ability to draw legend bounding boxes (for debugging, when using
Plots.debugplots(true)
).Fix centering of legend boxes (
:top
and:bottom
), and position of legend title.These examples should cover most of the legend boxes possibilities:
Supersedes #4444.
Xref #2423.
Added new examples to cover the issues encountered in #4485 and #4491:
![64_old](https://user-images.githubusercontent.com/13423344/200295773-9ad2142a-14f1-4dad-b2d7-d7ed55a1dbd0.png)
1.35.8 - inner - ex64
pr - inner - ex64
![ref64](https://github.com/JuliaPlots/PlotReferenceImages.jl/raw/master/Plots/gr/1.35.8/ref64.png)
1.35.8 - outer - ex65
![65_old](https://user-images.githubusercontent.com/13423344/200295808-7274ad6d-f462-4657-8063-2a14bf92afba.png)
pr - outer - ex65
![ref65](https://github.com/JuliaPlots/PlotReferenceImages.jl/raw/master/Plots/gr/1.35.8/ref65.png)