Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plotly colorbar size scale with plot size #4569

Merged
merged 2 commits into from Nov 30, 2022
Merged

Make plotly colorbar size scale with plot size #4569

merged 2 commits into from Nov 30, 2022

Conversation

stevenaleung
Copy link
Contributor

Closes #4547

These changes improve the default positioning of the colorbars

using Plots
data = rand(3, 3);
heatmap(data)

and also allow the colorbar size to scale with plot size

heatmap(data, colorbar=:right, tickfont=30, xlabel="test")

@t-bltg
Copy link
Member

t-bltg commented Nov 30, 2022

Thanks for this PR, please read and use https://docs.juliaplots.org/stable/contributing/#Write-code,-and-format for the format check to pass.

I don't know anything about plotly, so someone else might want to review this.

@t-bltg t-bltg added Plotly enhancement improving existing functionality labels Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 90.89% // Head: 90.95% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (64f8fa2) compared to base (816d0f4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4569      +/-   ##
==========================================
+ Coverage   90.89%   90.95%   +0.05%     
==========================================
  Files          40       40              
  Lines        7707     7802      +95     
==========================================
+ Hits         7005     7096      +91     
- Misses        702      706       +4     
Impacted Files Coverage Δ
src/backends/gaston.jl 95.52% <0.00%> (-0.52%) ⬇️
src/backends/gr.jl 91.65% <0.00%> (-0.02%) ⬇️
src/args.jl 84.70% <0.00%> (ø)
src/animation.jl 99.04% <0.00%> (ø)
src/axes.jl 90.61% <0.00%> (+0.08%) ⬆️
src/utils.jl 92.61% <0.00%> (+0.08%) ⬆️
src/examples.jl 97.59% <0.00%> (+0.33%) ⬆️
RecipesPipeline/src/type_recipe.jl 94.44% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t-bltg t-bltg merged commit 965d2d1 into JuliaPlots:master Nov 30, 2022
@t-bltg
Copy link
Member

t-bltg commented Nov 30, 2022

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improving existing functionality Plotly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Plotly colorbar size does not scale with plot size
3 participants