Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support plotting offset images #4615

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Conversation

simeonschaub
Copy link
Contributor

plot(::OffsetMatrix{<:Colorant}) currently fails, because the recipe
assumes all axes are one-based. I wasn't sure how to add a test for
this, so I'd appreciate any pointers.

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 90.64% // Head: 90.79% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (2f3d7c1) compared to base (e01af5a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4615      +/-   ##
==========================================
+ Coverage   90.64%   90.79%   +0.15%     
==========================================
  Files          41       41              
  Lines        8777     8779       +2     
==========================================
+ Hits         7956     7971      +15     
+ Misses        821      808      -13     
Impacted Files Coverage Δ
src/recipes.jl 84.58% <100.00%> (ø)
RecipesPipeline/src/RecipesPipeline.jl 100.00% <0.00%> (ø)
src/backends/pgfplotsx.jl 88.90% <0.00%> (+0.02%) ⬆️
src/components.jl 90.62% <0.00%> (+0.52%) ⬆️
RecipesPipeline/src/utils.jl 97.26% <0.00%> (+1.36%) ⬆️
RecipesPipeline/src/series.jl 93.58% <0.00%> (+2.56%) ⬆️
src/examples.jl 99.20% <0.00%> (+3.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeastyBlacksmith
Copy link
Member

I think adding a test that passes an OffsetArray to heatmap would catch this, no?
Would be enough to check that the recipe does not throw, no need for display.

@simeonschaub
Copy link
Contributor Author

heatmap for OffsetArray is actually broken in other fun ways, but I added two tests for my initial use case.

`plot(::OffsetMatrix{<:Colorant})` currently fails, because the recipe
assumes all axes are one-based. I wasn't sure how to add a test for
this, so I'd appreciate any pointers.
@simeonschaub
Copy link
Contributor Author

Any idea what's going on with the Conda errors?

@BeastyBlacksmith
Copy link
Member

Not yet :/

@t-bltg t-bltg merged commit 10dcc9f into JuliaPlots:master Jan 7, 2023
@simeonschaub simeonschaub deleted the sds/offset_img branch January 7, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants